Github user manuzhang commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/86#discussion_r80167763
  
    --- Diff: 
external/hbase/src/main/scala/org/apache/gearpump/external/hbase/HBaseSink.scala
 ---
    @@ -114,16 +118,19 @@ object HBaseSink {
       val COLUMN_FAMILY = "hbase.table.column.family"
       val COLUMN_NAME = "hbase.table.column.name"
       val HBASE_USER = "hbase.user"
    -
    -  def apply[T](userconfig: UserConfig, tableName: String): HBaseSink = {
    -    new HBaseSink(userconfig, tableName)
    -  }
    +  private val CONFIG = HBaseConfiguration.create()
    --- End diff --
    
    will configuration be created at client side ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to