Github user manuzhang commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/133#discussion_r96553846 --- Diff: core/src/main/scala/org/apache/gearpump/cluster/client/ClientContext.scala --- @@ -53,20 +55,21 @@ class ClientContext(config: Config, sys: ActorSystem, _master: ActorRef) { } private val LOG: Logger = LogUtil.getLogger(getClass) - private implicit val timeout = Timeout(5, TimeUnit.SECONDS) - implicit val system = Option(sys).getOrElse(ActorSystem(s"client${Util.randInt()}", config)) LOG.info(s"Starting system ${system.name}") - val shouldCleanupSystem = Option(sys).isEmpty - + private val shouldCleanupSystem = Option(sys).isEmpty --- End diff -- I'm thinking how `sys` can ever be empty here since we just created one above
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---