[
https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833351#comment-15833351
]
ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97216263
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/AppDescription.scala ---
@@ -139,4 +138,47 @@ case class ExecutorContext(
case class ExecutorJVMConfig(
classPath: Array[String], jvmArguments: Array[String], mainClass:
String,
arguments: Array[String], jar: Option[AppJar], username: String,
- executorAkkaConfig: Config = ConfigFactory.empty())
\ No newline at end of file
+ executorAkkaConfig: Config = ConfigFactory.empty())
+
+// Not using Enumeration here because upickle does not support it
--- End diff --
There are also some other reasons to prefer case object. Please check the
reference below.
> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
> Key: GEARPUMP-265
> URL: https://issues.apache.org/jira/browse/GEARPUMP-265
> Project: Apache Gearpump
> Issue Type: Sub-task
> Affects Versions: 0.8.2
> Reporter: Huafeng Wang
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
