[
https://issues.apache.org/jira/browse/GEARPUMP-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833815#comment-15833815
]
ASF GitHub Bot commented on GEARPUMP-265:
-----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/134#discussion_r97244923
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/client/RunningApplication.scala
---
@@ -18,17 +18,21 @@
package org.apache.gearpump.cluster.client
import akka.pattern.ask
-import akka.actor.ActorRef
+import akka.actor.{Actor, ActorRef, ActorSystem, Props}
import akka.util.Timeout
-import org.apache.gearpump.cluster.ClientToMaster.{ResolveAppId,
ShutdownApplication}
-import org.apache.gearpump.cluster.MasterToClient.{ResolveAppIdResult,
ShutdownApplicationResult}
+import
org.apache.gearpump.cluster.ClientToMaster.{RegisterAppResultListener,
ResolveAppId, ShutdownApplication}
+import org.apache.gearpump.cluster.MasterToClient.{ApplicationResult,
ResolveAppIdResult, ShutdownApplicationResult}
+import
org.apache.gearpump.cluster.client.RunningApplication.{AppResultListener,
WaitUntilFinish}
import org.apache.gearpump.util.ActorUtil
+import org.apache.gearpump.cluster.client.RunningApplication._
-import scala.concurrent.Future
+import scala.concurrent.duration._
+import scala.concurrent.{Await, Future}
import scala.util.{Failure, Success}
import scala.concurrent.ExecutionContext.Implicits.global
-class RunningApplication(val appId: Int, master: ActorRef, timeout:
Timeout) {
+class RunningApplication(val appId: Int, master: ActorRef, timeout:
Timeout,
+ system: ActorSystem) {
--- End diff --
Can we avoid passing `system` around ?
> remove AppMasterRuntimeInfo from AppMasterContext
> -------------------------------------------------
>
> Key: GEARPUMP-265
> URL: https://issues.apache.org/jira/browse/GEARPUMP-265
> Project: Apache Gearpump
> Issue Type: Sub-task
> Affects Versions: 0.8.2
> Reporter: Huafeng Wang
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
