[
https://issues.apache.org/jira/browse/GEARPUMP-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855923#comment-15855923
]
ASF GitHub Bot commented on GEARPUMP-23:
----------------------------------------
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/140#discussion_r99814058
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/api/WindowFunction.scala
---
@@ -33,11 +33,19 @@ object WindowFunction {
}
trait WindowFunction[T] {
+
def apply(context: WindowFunction.Context[T]): Array[Window]
+
+ def isNonMerging: Boolean
+}
+
+abstract class NonMergingWindowFunction[T] extends WindowFunction[T] {
+
+ override def isNonMerging: Boolean = true
--- End diff --
users are free to extend `WindowFunction`, which can not be matched
> Add DSL window (time series) support
> -------------------------------------
>
> Key: GEARPUMP-23
> URL: https://issues.apache.org/jira/browse/GEARPUMP-23
> Project: Apache Gearpump
> Issue Type: Sub-task
> Components: streaming
> Affects Versions: 0.8.0
> Reporter: Kam Kasravi
> Assignee: Manu Zhang
>
> Time series support is need for both GEARPUMP-21 and GEARPUMP-22. This was
> originally github issue
> [1917|https://github.com/gearpump/gearpump/issues/1917]. Other realtime
> streaming engines support time windows such as
> [Flink|https://flink.apache.org/news/2015/12/04/Introducing-windows.html],
> [Beam|https://www.oreilly.com/ideas/the-world-beyond-batch-streaming-101] and
> a future release of
> [Spark|https://issues.apache.org/jira/secure/attachment/12793410/StructuredStreamingProgrammingAbstractionSemanticsandAPIs-ApacheJIRA.pdf].
> A comparison matrix is found
> [here|https://docs.google.com/spreadsheets/d/1OM077lZBARrtUi6g0X0O0PHaIbFKCD6v0djRefQRE1I/edit#gid=995660187]
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
