[ 
https://issues.apache.org/jira/browse/GEARPUMP-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015040#comment-16015040
 ] 

ASF GitHub Bot commented on GEARPUMP-312:
-----------------------------------------

Github user huafengw commented on the issue:

    https://github.com/apache/incubator-gearpump/pull/183
  
    Can we and should we add an apply function in trait Message's companion 
object which returns a `DefaultMessage`?


> Allow Message to be extensible
> ------------------------------
>
>                 Key: GEARPUMP-312
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-312
>             Project: Apache Gearpump
>          Issue Type: Improvement
>    Affects Versions: 0.8.3
>            Reporter: Manu Zhang
>            Assignee: Manu Zhang
>
> The current {{case class Message(msg: Any, timeInMillis: TimeStamp)}} is not 
> extensible with an additional timestamp field while users' message may 
> already carry that information.  I don't think we care about what is stored 
> in the message but what we can get from it. 
> I propose to add a new interface {{Message}} with {{value}} and {{timestamp}} 
> fields/methods and rename the current {{Message}} to {{DefaultMessage}} as a 
> default implementation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to