Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/186#discussion_r121310835
--- Diff:
streaming/src/main/scala/org/apache/gearpump/streaming/source/Watermark.scala
---
@@ -30,7 +30,7 @@ case class Watermark(instant: Instant) {
object Watermark {
- val MAX: Instant = Instant.ofEpochMilli(MAX_TIME_MILLIS)
+ val MAX: Instant = Instant.ofEpochMilli(MAX_TIME_MILLIS + 1)
--- End diff --
Watermark means no more messages with timestamps **less than** the
watermark time should be seen. Hence, the maximum watermark time should be 1ms
larger than maximum timestamp
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
