Github user huafengw commented on a diff in the pull request:

    https://github.com/apache/incubator-gearpump/pull/187#discussion_r122588434
  
    --- Diff: 
streaming/src/main/scala/org/apache/gearpump/streaming/task/Subscription.scala 
---
    @@ -40,7 +41,7 @@ class Subscription(
         executorId: Int,
         taskId: TaskId,
         subscriber: Subscriber, sessionId: Int,
    -    transport: ExpressTransport,
    +    sender: TaskActor,
    --- End diff --
    
    I think here `sender` is just the current task actor, while literally 
sender means the upstream task actor 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to