Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/incubator-gearpump/pull/202#discussion_r129772131
--- Diff:
core/src/main/scala/org/apache/gearpump/cluster/embedded/EmbeddedCluster.scala
---
@@ -36,27 +36,21 @@ import org.apache.gearpump.util.{LogUtil, Util}
* Create a in-process cluster with single worker
*/
class EmbeddedCluster(inputConfig: Config) {
-
- private val workerCount: Int = 1
- private var _master: ActorRef = null
- private var _system: ActorSystem = null
- private var _config: Config = null
-
private val LOG = LogUtil.getLogger(getClass)
+ private val workerCount: Int = 1
+ var _master: ActorRef = _
--- End diff --
Do we have to expose these mutable variables ? BTW, how about removing the
prefix "_" since I don't see any conflicts here ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
