Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/213#discussion_r132863041 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/window/impl/WindowRunner.scala --- @@ -137,11 +156,14 @@ class DefaultWindowRunner[IN, OUT]( } onTrigger(outputs, newWmk) } else { - // minimum of end of last triggered window and start of first un-triggered window + // The output watermark is the minimum of end of last triggered window + // and start of first un-triggered window TriggeredOutputs(outputs, TaskUtil.min(wmk, firstWin.startTime)) } } else { + // All windows have been triggered. if (time == Watermark.MAX) { + // This means there will no more inputs so it's safe to advance to the maximum watermark. --- End diff -- there will be no more
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---