[
https://issues.apache.org/jira/browse/GEARPUMP-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153340#comment-16153340
]
ASF GitHub Bot commented on GEARPUMP-349:
-----------------------------------------
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-gearpump/pull/223
#
[Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/223?src=pr&el=h1)
Report
> Merging
[#223](https://codecov.io/gh/apache/incubator-gearpump/pull/223?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gearpump/commit/b79fb2445b88f0e7aab71e72404ca5a449fc97f1?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `96%`.
```diff
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 69.05% 69.03% -0.03%
==========================================
Files 191 191
Lines 6104 6116 +12
Branches 350 352 +2
==========================================
+ Hits 4215 4222 +7
- Misses 1889 1894 +5
```
> Graph#topologicalOrderIterator is slow for large graph
> ------------------------------------------------------
>
> Key: GEARPUMP-349
> URL: https://issues.apache.org/jira/browse/GEARPUMP-349
> Project: Apache Gearpump
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.8.4
> Reporter: Manu Zhang
> Assignee: Huafeng Wang
> Fix For: 0.8.5
>
>
> The algorithm is as follows
> 1. find zero in-degree nodes from a copied graph.
> 2. remove nodes from the copied graph and add them to the output
> 3. repeat 1
> The issue is that step 1 traverses all remaining nodes each time, which costs
> the algorithm {{O(n^2)}} time
> {{Graph#hasCycle}} has a similar issue
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
