[ 
https://issues.apache.org/jira/browse/GEARPUMP-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426697#comment-16426697
 ] 

ASF GitHub Bot commented on GEARPUMP-369:
-----------------------------------------

GitHub user manuzhang opened a pull request:

    https://github.com/apache/incubator-gearpump/pull/242

    [GEARPUMP-369] Fix configuring number of executors

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the commit message is formatted like:
       `[GEARPUMP-<Jira issue #>] Meaningful description of pull request` 
     - [ ] Make sure tests pass via `sbt clean test`.
     - [ ] Make sure old documentation affected by the pull request has been 
updated and new documentation added for new functionality. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/manuzhang/incubator-gearpump 
fix_config_executor_num

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-gearpump/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #242
    
----
commit 669f4e1ea4669d98fe34a56900bd41a03918787d
Author: manuzhang <owenzhang1990@...>
Date:   2018-04-05T10:04:35Z

    [GEARPUMP-369] Fix configuring number of executors

----


> "executor-num" is overridden by the default value for arg "executors"(1) 
> -------------------------------------------------------------------------
>
>                 Key: GEARPUMP-369
>                 URL: https://issues.apache.org/jira/browse/GEARPUMP-369
>             Project: Apache Gearpump
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.4, 0.8.5
>            Reporter: Hashan Gayasri Udugahapattuwa
>            Priority: Minor
>
> org/apache/gearpump/cluster/main/AppSubmitter.scala:62
> System.setProperty(Constants.APPLICATION_EXECUTOR_NUMBER, 
> config.getInt("executors").toString)
>  
> replaces the value set by system properties (gear.conf) by the default 
> value(1) even when no value is passed at as an argument. The expected 
> behaviour is to only override the value when a value is given explicitly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to