----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53910/#review156360 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java (line 246) <https://reviews.apache.org/r/53910/#comment226578> Shouldn't this be modified |= add? geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java (line 258) <https://reviews.apache.org/r/53910/#comment226579> modified |= remove - Dan Smith On Nov. 19, 2016, 12:01 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53910/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2016, 12:01 a.m.) > > > Review request for geode, Barry Oglesby and Dan Smith. > > > Repository: geode > > > Description > ------- > > StructSet add all should use the overridden add method. This prevents > StructImpls from entering the set and converts them to Object[] > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java > 6d04c02 > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/SelectStarQueryDUnitTest.java > 4596fdc > > Diff: https://reviews.apache.org/r/53910/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
