GitHub user davinash opened a pull request:
https://github.com/apache/incubator-geode/pull/295
[GEODE-1984] #comment Fix Issue Make GatewaySender destroy a public API
1. Making destory API public
2. Added a new gfsh WAN command destroyGatewaySender
3. Impleted GatewaySenderDestroyFunction, which first stop gatewaysender
and then call destroy on the same.
4. Added a WAN Rest Controller for destroy gatewaysender
5. Removed the need of explicit casting of sender to AbstractGatewaySender
for calling
destroy API
6. Renamed Test WanCommandCreateGatewaySenderDUnitTest to
WanCommandCreateDestroyGatewaySenderDUnitTest
7. Each applicable test now also calls destroy gfsh command and verfies the
result
8. Minor changes in the logging for each tests
Precheckin is passing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinash/incubator-geode feature/GEODE-1984
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #295
----
commit 008309dd6bd01d101071c6caa1786657e84953b3
Author: Anthony Baker <[email protected]>
Date: 2016-02-08T16:58:07Z
Merge branch 'release/1.0.0-incubating.M1'
commit 347d78ce0c9f2fe53d619aef60381fb2f3d8f919
Author: Lynn Hughes-Godfrey <[email protected]>
Date: 2016-04-07T20:49:02Z
Added keys for Lynn Hughes-Godfrey
commit a745ce9e9a9f706c6b4977ae059852be3994e8ab
Author: Dan Smith <[email protected]>
Date: 2016-04-22T00:36:50Z
Merge branch 'release/1.0.0-incubating.M2'
Overrode the KEYS file that was accidentally checked in to master.
commit 2e1075246a5c95dcd087fe497bae0df323acfdbd
Author: Anthony Baker <[email protected]>
Date: 2016-08-22T16:38:09Z
Merge branch 'release/1.0.0-incubating.M3'
commit c3162e0b9d7315c4665ebd05e26515228f9e89de
Author: zhouxh <[email protected]>
Date: 2016-10-10T18:20:25Z
GEODE-1956: fix the race condition that cause the vm only hosts 1 primary
bucket
commit 639c856021ec9321cdc0895a5e1503a6296dc765
Author: Anthony Baker <[email protected]>
Date: 2016-10-10T18:38:51Z
Revert "GEODE-1956: fix the race condition that cause the vm only hosts 1
primary bucket"
This reverts commit c3162e0b9d7315c4665ebd05e26515228f9e89de.
commit 09d7b5ce2817bcd1ae7e7b09f32dce995b9cfcf5
Author: Swapnil Bawaskar <[email protected]>
Date: 2016-10-25T06:18:28Z
Merge branch 'release/1.0.0-incubating'
commit bf1fba82163b0c65857dbaf70eca3bcda2e40f1e
Author: adongre <[email protected]>
Date: 2016-11-19T09:45:43Z
Merge remote-tracking branch 'upstream/master' into develop
commit f4521776eeccb36ad9e9d80c1d322e38492334ab
Author: adongre <[email protected]>
Date: 2016-11-19T09:47:35Z
Merge remote-tracking branch 'upstream/develop' into develop
commit 6af49b5e4e0fef85fa31cf9f9af539773baf7178
Author: adongre <[email protected]>
Date: 2016-11-19T10:34:53Z
GEODE-1984: Making public GateWaySender API 'destroy'
commit 93d4c08e2923474b40b153f7cabfbda0dce20ef8
Author: adongre <[email protected]>
Date: 2016-11-19T15:26:25Z
GEODE-1984: Started writing gfsh command for destroy gateway-sender
commit c8228f16a6c984bf8cf1e94533d9e88231311dd4
Author: adongre <[email protected]>
Date: 2016-11-19T17:40:45Z
GEODE-1984: Added a new WanCommand to destroy a gateway-sender
Implemented GatewaySenderDestroyFunctionArgs and
GatewaySenderDestroyFunction
Started writing a test for destroy functionality. [ WIP ]
commit eb994e1320af01c3e37697b9d942fd25c181c01c
Author: adongre <[email protected]>
Date: 2016-11-20T12:08:11Z
GEODE-1984: Fixing the logic of destroying a gateway sender, one need to
stop
the gatewaySender before calling destroy.
commit 43e45a96891fbc5338e5e9649b297f8372b15c88
Author: adongre <[email protected]>
Date: 2016-11-20T15:25:37Z
GEODE-1984: 1. Added verifySenderDestroyed from WANTestBase to
WANCommandTestBase
2. Moved Test WanCommandCreateGatewaySenderDUnitTest to
WanCommandCreateDestroyGatewaySenderDUnitTest to include
gateway-sender destroy command
3. Updating the logging in all the tests
commit 24a4dc44e8d00ba9c56d828fb311dbae42974dfc
Author: adongre <[email protected]>
Date: 2016-11-21T08:33:48Z
GEODE-1984: Adding more Tests and fixing the error message
commit d15f7d6d5f494b1ba905790a329eb2cc724f5680
Author: adongre <[email protected]>
Date: 2016-11-22T06:35:37Z
GEODE-1984: 1. Fixing Test failures for
ShellCommandsControllerJUnitTest,AnalyzeSerializablesJUnitTest,HelpCommandsIntegrationTest,HelpCommandsIntegrationTest
2. Added Rest Request for gateway-sender destroy in WanCommandsController
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
