Github user metatype commented on a diff in the pull request:

    https://github.com/apache/incubator-geode/pull/299#discussion_r90025760
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/statistics/StatMonitorHandler.java
 ---
    @@ -110,7 +100,7 @@ public void sampled(long nanosTimeStamp, 
List<ResourceInstance> resourceInstance
       }
     
       private void monitor(final long sampleTimeMillis, final 
List<ResourceInstance> resourceInstance) {
    -    List<StatisticsMonitor> currentMonitors = 
StatMonitorHandler.this.monitors;
    +    ConcurrentHashSet<StatisticsMonitor> currentMonitors = 
StatMonitorHandler.this.monitors;
    --- End diff --
    
    I don't think this copy is needed since `monitors` is never updated after 
initialization.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to