Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90295325
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExplicitConnectionSourceImpl.java
---
@@ -257,7 +257,7 @@ public String toString() {
return sb.toString();
}
- ArrayList<ServerLocation> getAllServers() {
+ public ArrayList<ServerLocation> getAllServers() {
--- End diff --
Better to add @Override here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
