Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/303#discussion_r91390603
--- Diff:
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/wancommand/WanCommandCreateDestroyGatewaySenderDUnitTest.java
---
@@ -55,7 +55,7 @@ private CommandResult
executeCommandWithIgnoredExceptions(String command) {
* GatewaySender with all default attributes
--- End diff --
Would it make sense to create different tests for destroy and keep them
separate from testing create? That way when a test fails we know exactly what
is failing (create vs destroy).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
