[
https://issues.apache.org/jira/browse/GEODE-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730227#comment-15730227
]
ASF GitHub Bot commented on GEODE-734:
--------------------------------------
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/297
I created feature/GEODE-734 branch and pulled in all changes. I also did a
git rebase and combined all commits into a single commit:
commit 2c5a0a1688b821f95584ef4b6610c65d0433d2e7
Author: Deepak Dixit <deepakdixit2...@gmail.com>
Date: Sat Nov 26 19:11:52 2016 +0530
GEODE-734: Remove txt file restriction when exporting stack traces
Adding throws clause to signature instead of catching it in Test.
Separating test scenarios into multiple test cases. Creating files in
TemporaryFolder.
Applying spotless checks
Updated export stack-traces in controller. Removed compulsory file
option. If file is not provided then name is generated. Added one
boolean option fail-if-file-present, if true and file already exists
then command will fail.
Updated Offline help file.
Added test cases to verify new added options
Removed compulsory file option. If file is not provided then name is
generated. Added one boolean option fail-if-file-present, if true and
file already exists then command will fail.
Added message warning user about possible overwrite of file if already
present.
Added test to check if non txt extension file is allowed.
This closes #297
> gfsh export stack-traces should not require an output file with extension .txt
> ------------------------------------------------------------------------------
>
> Key: GEODE-734
> URL: https://issues.apache.org/jira/browse/GEODE-734
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jens Deppe
>
> gfsh {{export stack-traces}} requires a file with a {{.txt}} extension:
> {noformat}
> gfsh>export stack-traces --file=/tmp/trace.log
> Invalid file type, the file extension must be ".txt"
> {noformat}
> This seems like a totally arbitrary restriction. Please can it be removed.
> If the concern is that an existing file might be overwritten then we should
> have a user prompt indicating that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
