[
https://issues.apache.org/jira/browse/GEODE-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755290#comment-15755290
]
ASF GitHub Bot commented on GEODE-1995:
---------------------------------------
Github user dschneider-pivotal commented on the issue:
https://github.com/apache/geode/pull/315
I think you should continue to remove code that was only used by
ReliableMessageQueueFactoryImpl. This included the following:
1. LocalizedStrings that this class used.
2. ReliableDistributionData: the methods on this interface were only called
by ReliableMessageQueueFactoryImpl. So this interface should be removed and all
the implementations of this interface (lots of *Message classes).
3. DistributedRegion.sendQueue method: it is only called by
ReliableMessageQueueFactoryImpl.
Getting rid of that method lets you delete SendQueueOperation which gets
rid of SendQueueMessage which lets you get rid of SEND_QUEUE_MESSAGE (you will
need to also remove some references for this message from DSFIDFactory).
It would be best to remove all this stuff with one checkin. Just just look
over each class you remove and see what it references that will no longer be
used.
> remove ReliableMessageQueueFactory, ReliableMessageQueue, and
> getReliableMessageQueueFactory
> --------------------------------------------------------------------------------------------
>
> Key: GEODE-1995
> URL: https://issues.apache.org/jira/browse/GEODE-1995
> Project: Geode
> Issue Type: Improvement
> Components: regions
> Reporter: Darrel Schneider
> Assignee: Avinash Dongre
>
> ReliableMessageQueueFactory, ReliableMessageQueue, and
> GemFireCacheImpl.getReliableMessageQueueFactory should all be removed. They
> are internal and were never used. No tests exist for them.
> They are part of required Roles which is a deprecated feature.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
