Github user metatype commented on a diff in the pull request:
https://github.com/apache/geode/pull/321#discussion_r93149349
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/execute/Execution.java ---
@@ -89,7 +89,7 @@
*
* @since GemFire 6.0
*/
- public ResultCollector<?, ?> execute(String functionId) throws
FunctionException;
+ public <T, S> ResultCollector<T, S> execute(String functionId) throws
FunctionException;
--- End diff --
Since this is a public API, you should describe the params in javadoc when
it's not obvious what T and S refer to. You can use the `@param` tag as seen
in [1].
[1]
https://github.com/apache/geode/blob/8bf39571471642beaaa36c9626a61a90bd3803c2/geode-core/src/main/java/org/apache/geode/cache/snapshot/RegionSnapshotService.java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
