----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/#review159759 -----------------------------------------------------------
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 100) <https://reviews.apache.org/r/54916/#comment230808> Does this test reall need to do 10K puts? Can we scale it down? geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 103) <https://reviews.apache.org/r/54916/#comment230809> A 3 second wait seems really short. Likely will cause spurious failures? geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 105) <https://reviews.apache.org/r/54916/#comment230810> Maybe stopSender could be triggered by a cache listener in the remote side or something to make this test more deterministic? - Dan Smith On Dec. 20, 2016, 10 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54916/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 10 p.m.) > > > Review request for geode, nabarun nag and Dan Smith. > > > Repository: geode > > > Description > ------- > > Fixes to make the test less timing based. > > > Diffs > ----- > > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java > 3ed867a > > Diff: https://reviews.apache.org/r/54916/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
