[
https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773693#comment-15773693
]
ASF subversion and git services commented on GEODE-165:
-------------------------------------------------------
Commit 16e2cfcdd9fc0fb9c7e5213cf68c68257cba7780 in geode's branch
refs/heads/feature/GEODE-2231 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=16e2cfc ]
GEODE-165: Removed OQL generated files and added the target into
geode-core/build.gradle.
GEODE-165 : Updating spotless configuration to exclude 'generated-src'
directory.
> Add build support for generating antlr classes from grammar
> -----------------------------------------------------------
>
> Key: GEODE-165
> URL: https://issues.apache.org/jira/browse/GEODE-165
> Project: Geode
> Issue Type: Bug
> Components: build
> Reporter: Dan Smith
> Assignee: Avinash Dongre
>
> The OQL engine currently uses antlr to generate some parsing classes from
> gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/oql.g
> These are the generated classes. They are currently checked into the source.
> OQLLexer.java
> OQLLexerTokenTypes.java
> OQLLexerTokenTypes.txt
> OQLParser.java
> They can be generated manually by running antlr.Tool on the provided grammar.
> cd gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/parse/
> java -cp antlr.jar antlr.Tool oql.g
> We should add support to the gradle build to generate these classes.
> In my opinion we should also remove the checked in classes. With gradle we
> can configure things so that the gradle eclipse target will generate these
> classes and make them available to the IDE as well. Look at
> gemfire-core/build.gradle for how we do this with the version properties file:
> sourceSets {
> main {
> output.dir(generatedResources, builtBy: 'createVersionPropertiesFile')
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
