[ https://issues.apache.org/jira/browse/GEODE-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802091#comment-15802091 ]
ASF GitHub Bot commented on GEODE-1407: --------------------------------------- Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/313#discussion_r94819019 --- Diff: geode-core/src/test/java/org/apache/geode/cache30/ReconnectDUnitTest.java --- @@ -534,41 +532,35 @@ public Object call() throws CacheException { Cache cache = getCache(); Region myRegion = cache.getRegion("root/myRegion"); myRegion.put("MyKey1", "MyValue1"); - // myRegion.put("Mykey2", "MyValue2"); return savedSystem.getDistributedMember(); } }; vm1.invoke(create1); - try { - dm = getDMID(vm0); createGfshWaitingThread(vm0); forceDisconnect(vm0); newdm = waitForReconnect(vm0); assertGfshWaitingThreadAlive(vm0); - vm0.invoke(new SerializableRunnable("check for running locator") { - public void run() { - WaitCriterion wc = new WaitCriterion() { - public boolean done() { - return Locator.getLocator() != null; - } - - public String description() { - return "waiting for locator to restart"; - } - }; - Wait.waitForCriterion(wc, 30000, 1000, false); + boolean running = (Boolean) vm0.invoke(new SerializableCallable("check for running locator") { --- End diff -- This can be written as a "proper" Lambda if you wanted to continue the refactor. vm0.invoke("check for running locator", () -> {...}); > CI Failure: ReconnectDUnitTest.testReconnectALocator > ---------------------------------------------------- > > Key: GEODE-1407 > URL: https://issues.apache.org/jira/browse/GEODE-1407 > Project: Geode > Issue Type: Bug > Components: membership > Reporter: Sai Boorlagadda > Labels: ci > > Related to GEODE-598. Opening a new one. > {noformat} > Error Message > junit.framework.AssertionFailedError: expected the restarted member to be > hosting a running locator > Stacktrace > junit.framework.AssertionFailedError: expected the restarted member to be > hosting a running locator > at junit.framework.Assert.fail(Assert.java:57) > at junit.framework.TestCase.fail(TestCase.java:227) > at > com.gemstone.gemfire.cache30.ReconnectDUnitTest.testReconnectALocator(ReconnectDUnitTest.java:548) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at junit.framework.TestCase.runTest(TestCase.java:176) > at junit.framework.TestCase.runBare(TestCase.java:141) > at junit.framework.TestResult$1.protect(TestResult.java:122) > at junit.framework.TestResult.runProtected(TestResult.java:142) > at junit.framework.TestResult.run(TestResult.java:125) > at junit.framework.TestCase.run(TestCase.java:129) > at junit.framework.TestSuite.runTest(TestSuite.java:252) > at junit.framework.TestSuite.run(TestSuite.java:247) > at > org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:112) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360) > at > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54) > at > org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:745) > Standard Output > Previously run tests: [GlobalRegionCCEOffHeapDUnitTest, > ClearMultiVmDUnitTest, CacheXml45DUnitTest, SearchAndLoadDUnitTest, > DistributedAckPersistentRegionCCEOffHeapDUnitTest, > PartitionedRegionDUnitTest, PutAllCallBkSingleVMDUnitTest, > PartitionedRegionOffHeapDUnitTest, ReconnectDUnitTest] > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)