Github user jinmeiliao commented on a diff in the pull request:

    https://github.com/apache/geode/pull/327#discussion_r95418869
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/RegionAlterFunction.java
 ---
    @@ -237,7 +237,7 @@ public void execute(FunctionContext context) {
               }
             }
     
    -        if (!nameFound) {
    +        if (!nameFound && !newCacheListenerName.isEmpty()) {
    --- End diff --
    
    instead of adding the check here, would it be better to add the check in 
line after 232:
    if(newCacheListnerName.isEmpty()) break;


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to