GitHub user vectorijk opened a pull request:

    https://github.com/apache/geode/pull/348

    [GEODE-2172] CustomConfigWithCacheIntegrationTest fails with AssertionError 
on Windows

    > The issues is related to incorrect regex pattern. The regex pattern used 
to match log string contains newline character. To fix this issue, I've 
replaced Unix newline character in regex pattern into System.lineSeparator(), a 
Platform-dependent newline character in Java.
    > 
    > I've run this unit test both on Windows and MacOS. And it passes.
    
    Review Board: 
[https://reviews.apache.org/r/54586/](https://reviews.apache.org/r/54586/)
    
    Since this has been marked as `Ship it`, this PR here will be easy for 
merging.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vectorijk/geode GEODE-2172

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/348.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #348
    
----
commit bc33c54e7afa5c8d09a18ec857ff385559639e0a
Author: Kai Jiang <jiang...@gmail.com>
Date:   2016-12-09T12:43:16Z

    reason

commit e407c12546de05492580b9cfdf1fbe8db7068782
Author: Kai Jiang <jiang...@gmail.com>
Date:   2016-12-19T12:38:10Z

    delete unused test method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to