[ 
https://issues.apache.org/jira/browse/GEODE-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832136#comment-15832136
 ] 

ASF GitHub Bot commented on GEODE-2326:
---------------------------------------

Github user metatype commented on the issue:

    https://github.com/apache/geode/pull/346
  
    LGTM


> Fix broken integration test testLogger
> --------------------------------------
>
>                 Key: GEODE-2326
>                 URL: https://issues.apache.org/jira/browse/GEODE-2326
>             Project: Geode
>          Issue Type: Test
>          Components: native client
>            Reporter: David Kimura
>
> Banner length is hardcoded in this test.  This led to test broking after 
> changing to banner to Apache License.
> Test can be fixed by adjusting the hardcoded length like so..
> {noformat}
> $ git diff
> diff --git a/src/cppcache/integration-test/testLogger.cpp 
> b/src/cppcache/integration-test/testLogger.cpp
> index 6de4e68..8695bf1 100644
> --- a/src/cppcache/integration-test/testLogger.cpp
> +++ b/src/cppcache/integration-test/testLogger.cpp
> @@ -24,7 +24,7 @@
>  #include <unistd.h>
>  #endif
> -#define LENGTH_OF_BANNER 9
> +#define LENGTH_OF_BANNER 16
>  using namespace gemfire;
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to