----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55785/#review162505 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Jan. 20, 2017, 9:13 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55785/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 9:13 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jared Stewart, > Kevin Duling, and Udo Kohlmeyer. > > > Bugs: GEODE-2297 > https://issues.apache.org/jira/browse/GEODE-2297 > > > Repository: geode > > > Description > ------- > > GEODE-2297: push new InternalDistributedSystem into AlertAppender > > * InternalDistributedSystem initialize pushes its instance into > AlertAppender > > * During AlertAppender shuttingDown, it nulls out the reference > to InternalDistributedSystem > > This is an initial fix to prevent deadlocks. After merging this fix in, I'd > like to start refactoring AlertAppender as a follow-up. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > fad9206583fdc093b1f74397c321442335cf80d4 > > geode-core/src/main/java/org/apache/geode/internal/logging/log4j/AlertAppender.java > a6c54aba352ba4dd3ece94c94f770292db6e9284 > > Diff: https://reviews.apache.org/r/55785/diff/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
