Galen O'Sullivan created GEODE-2381:
---------------------------------------
Summary: Make enums not get so mangled by Spotless
Key: GEODE-2381
URL: https://issues.apache.org/jira/browse/GEODE-2381
Project: Geode
Issue Type: Bug
Reporter: Galen O'Sullivan
Perhaps the worst example is in {{CacheXMLVersion}}:
{code}
GEMFIRE_3_0(CacheXml.VERSION_3_0, CacheXml.PUBLIC_ID_3_0,
CacheXml.SYSTEM_ID_3_0, null,
null), GEMFIRE_4_0(CacheXml.VERSION_4_0, CacheXml.PUBLIC_ID_4_0,
CacheXml.SYSTEM_ID_4_0, null,
null), GEMFIRE_4_1(CacheXml.VERSION_4_1, CacheXml.PUBLIC_ID_4_1,
CacheXml.SYSTEM_ID_4_1,
null, null), GEMFIRE_5_0(CacheXml.VERSION_5_0,
CacheXml.PUBLIC_ID_5_0,
CacheXml.SYSTEM_ID_5_0, null, null),
GEMFIRE_5_1(CacheXml.VERSION_5_1,
CacheXml.PUBLIC_ID_5_1, CacheXml.SYSTEM_ID_5_1, null,
null), GEMFIRE_5_5(
CacheXml.VERSION_5_5, CacheXml.PUBLIC_ID_5_5,
CacheXml.SYSTEM_ID_5_5,
null, null), GEMFIRE_5_7(CacheXml.VERSION_5_7,
CacheXml.PUBLIC_ID_5_7,
CacheXml.SYSTEM_ID_5_7, null, null),
GEMFIRE_5_8(CacheXml.VERSION_5_8,
CacheXml.PUBLIC_ID_5_8, CacheXml.SYSTEM_ID_5_8,
null,
null), GEMFIRE_6_0(CacheXml.VERSION_6_0,
CacheXml.PUBLIC_ID_6_0,
CacheXml.SYSTEM_ID_6_0, null, null),
GEMFIRE_6_1(
CacheXml.VERSION_6_1,
CacheXml.PUBLIC_ID_6_1,
CacheXml.SYSTEM_ID_6_1, null, null),
GEMFIRE_6_5(
CacheXml.VERSION_6_5,
CacheXml.PUBLIC_ID_6_5,
CacheXml.SYSTEM_ID_6_5, null,
null), GEMFIRE_6_6(
CacheXml.VERSION_6_6,
CacheXml.PUBLIC_ID_6_6,
CacheXml.SYSTEM_ID_6_6, null,
null), GEMFIRE_7_0(
CacheXml.VERSION_7_0,
CacheXml.PUBLIC_ID_7_0,
CacheXml.SYSTEM_ID_7_0,
null,
null),
GEMFIRE_8_0(CacheXml.VERSION_8_0,
CacheXml.PUBLIC_ID_8_0,
CacheXml.SYSTEM_ID_8_0,
null,
null),
GEMFIRE_8_1(CacheXml.VERSION_8_1,
null, null,
CacheXml.SCHEMA_8_1_LOCATION,
CacheXml.GEMFIRE_NAMESPACE),
{code}
I'd love to just format these one per line. This can be done by changing a
single line in the Spotless eclipse formatter xml file (I'll put up a PR in
just a minute).
I'm not sure how attached we are to using {{eclipse-java-google-style.xml}} in
the same format as upstream (where did it come from exactly?). I also noticed
that Google has [their own tool|https://github.com/google/google-java-format]
for formatting text. Probably what we have is fine for now, and this
modification will make it better.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
