-1 (binding) I dug into the geode-old-versions project some more. It looks like we may not be running the backwards compatibility tests. I filed this bug, which I think we should fix before shipping:
GEODE-2433 - Backwards compatibility tests are not actually running If we're spinning another RC, it would be nice to also fix this issue I just noticed. I can pick up this one: GEODE-2432 - Don't create and upload empty maven artifacts for geode-benchmarks, geode-old-versions I also think we should get the jars Anthony mentioned out of the source. I'm still trying to dig up the emails, but we had to remove gradle-wrapper.jar from the source distro because it violated policy. If we can't include that, I doubt we can include these other jars either. -Dan On Mon, Feb 6, 2017 at 8:52 AM, Anthony Baker <aba...@pivotal.io> wrote: > Correct. Let me know if you need help converting these files to gradle > tasks. > > Anthony > > > > On Feb 6, 2017, at 8:10 AM, Jinmei Liao <jil...@pivotal.io> wrote: > > > > Oh, these are used by the tests, and the classes they contain are only > test > > classes as well. So we need to programmatically produce these jars and > zips > > during build time? > > > > On Mon, Feb 6, 2017 at 8:05 AM, Anthony Baker <aba...@pivotal.io> wrote: > > > >> -1 (binding) > >> > >> `gradle rat` shows these binary files are included in the src > distribution: > >> > >> + /Users/abaker/working/apache-geode-src-1.1.0/geode-core/ > >> src/test/resources/org/apache/geode/management/internal/ > >> configuration/cluster.jar > >> > >> + /Users/abaker/working/apache-geode-src-1.1.0/geode-core/ > >> src/test/resources/org/apache/geode/management/internal/ > >> configuration/cluster_config.zip > >> > >> + /Users/abaker/working/apache-geode-src-1.1.0/geode-core/ > >> src/test/resources/org/apache/geode/management/internal/ > >> configuration/cluster_config_security.zip > >> > >> + /Users/abaker/working/apache-geode-src-1.1.0/geode-core/ > >> src/test/resources/org/apache/geode/management/internal/ > >> configuration/group1.jar > >> > >> + /Users/abaker/working/apache-geode-src-1.1.0/geode-core/ > >> src/test/resources/org/apache/geode/management/internal/ > >> configuration/group2.jar > >> > >> > >> If tests require binary files, those files should be generated from > source > >> during the build. > >> > >> Anthony > >> > >>> On Feb 3, 2017, at 4:11 PM, Hitesh Khamesra > <hitesh...@yahoo.com.INVALID> > >> wrote: > >>> > >>> All, > >>> > >>> This is the first release candidate of the first release for Apache > >> Geode, version 1.1.0. > >>> Thanks to all the community members. > >>> > >>> It fixes the following issues: > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > >> projectId=12318420&version=12338352 > >>> > >>> > >>> *** Please download, test and vote by Wednesday, February 08, 0800 hrs > >> US Pacific. > >>> > >>> Note that we are voting upon the source (tag): > >>> rel/v1.1.0.RC1 > >>> https://git-wip-us.apache.org/repos/asf?p=geode.git;a=tag;h= > >> refs/tags/rel/v1.1.0.RC1 > >>> > >>> Commit ID: 90760d334f912cef49ad32f275aed9cd9f1f2688 > >>> > >>> Source and binary files: > >>> https://dist.apache.org/repos/dist/dev/geode/1.1.0.RC1/ > >>> > >>> Maven staging repo: > >>> https://repository.apache.org/content/repositories/ > >> orgapachegeode-1015/ > >>> > >>> Geode's KEYS file containing PGP keys we use to sign the release: > >>> https://github.com/apache/geode/blob/release/1.1.0/KEYS > >>> > >>> pub 4096R/AC6AB8ED 2017-01-18 > >>> Key fingerprint = 048F B40F AD7D 9C15 54AD D447 2CA9 90A2 AC6A > >> B8ED > >>> > >>> Thanks, > >>> Dan & Hitesh (on behalf of the Geode team) > >> > >> > > > > > > -- > > Cheers > > > > Jinmei > >
