----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56398/#review164531 -----------------------------------------------------------
Ship it! Awesome! - Dan Smith On Feb. 7, 2017, 6:10 p.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56398/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 6:10 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: geode-2400 > https://issues.apache.org/jira/browse/geode-2400 > > > Repository: geode > > > Description > ------- > > 1) move the waitUntilFlushed from LuceneIndex into LuceneService. > 2) use function > 3) handle cacheClosedException > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/DSFIDFactory.java > bb29239 > > geode-core/src/main/java/org/apache/geode/internal/DataSerializableFixedID.java > 84eb8e9 > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java > 1f8704c > > geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinator.java > a4c03a9 > > geode-core/src/test/java/org/apache/geode/internal/cache/wan/parallel/WaitUntilParallelGatewaySenderFlushedCoordinatorJUnitTest.java > c8b8ba1 > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java > 802b21a > geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java > 0ff5f0e > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java > 8d24a83 > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneServiceImpl.java > 70061eb > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunctionContext.java > PRE-CREATION > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/xml/LuceneIndexCreation.java > 030dddd > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneIndexMaintenanceIntegrationTest.java > e6c4503 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesBase.java > a56fff7 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java > d11ea91 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPRBase.java > c877f93 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesPersistenceIntegrationTest.java > 5ec09f1 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexImplJUnitTest.java > aaa6dbd > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexRecoveryHAIntegrationTest.java > d194081 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneServiceImplJUnitTest.java > 1815663 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommandsDUnitTest.java > 2bb5b4b > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/directory/DumpDirectoryFilesIntegrationTest.java > 5c47e13 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/IndexRepositorySpy.java > d363903 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/test/LuceneTestUtilities.java > 9f062bb > > Diff: https://reviews.apache.org/r/56398/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >