----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56399/ -----------------------------------------------------------
Review request for geode, Barry Oglesby, Jason Huynh, Lynn Hughes-Godfrey, Dan Smith, and xiaojian zhou. Repository: geode Description ------- Issue: ====== * Initially, the endQuery call in the finally block was responsible for incrementing the queries executed stat. * Even if there was an exception, the stat was incremented because of the finally block. * In case of retries during bucket not found exception, the number of queries executed keeps increasing. * This results in tests failures where it is expecting one query to be executed but finds multiple entries. Solution: ========= * The queries executed stat is not incremented in the finally block. * It is incremented just before the lastResult calll. Diffs ----- geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexStats.java a914799 geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneFunction.java fd908de geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/LuceneIndexStatsJUnitTest.java f9e200a Diff: https://reviews.apache.org/r/56399/diff/ Testing ------- geode-lucene:precheckin passed Thanks, nabarun nag
