----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56333/#review164815 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/tx/ClientTXStateStub.java (line 243) <https://reviews.apache.org/r/56333/#comment236607> instead of catching Exception here how about just setting txRollback on the rollback method? geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java (line 3975) <https://reviews.apache.org/r/56333/#comment236608> instead of creating the t2 thread try changing your test to just call doJTATx2 here. - Darrel Schneider On Feb. 8, 2017, noon, Eric Shu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56333/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, noon) > > > Review request for geode, anilkumar gingade and Darrel Schneider. > > > Bugs: GEODE-2429 > https://issues.apache.org/jira/browse/GEODE-2429 > > > Repository: geode > > > Description > ------- > > Do not run JTA afterCompletion on server if beforeCompletion is failed. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tx/ClientTXStateStub.java > e79324d > geode-core/src/main/java/org/apache/geode/internal/jta/TransactionImpl.java > f36079a > > geode-core/src/test/java/org/apache/geode/internal/cache/ClientServerTransactionDUnitTest.java > 270fbce > > Diff: https://reviews.apache.org/r/56333/diff/ > > > Testing > ------- > > precheckin. > > > Thanks, > > Eric Shu > >
