----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56457/#review164820 -----------------------------------------------------------
I don't think logging something and continuing is the appropriate way to handle failures. Maybe the code that actually uses versions should be what triggers this intialization, and we throw the exception and fail at that point, rather than doing this stuff in a static initializer? - Dan Smith On Feb. 8, 2017, 8:57 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56457/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 8:57 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-2433 > https://issues.apache.org/jira/browse/GEODE-2433 > > > Repository: geode > > > Description > ------- > > Modified to look for the file on the class-path instead of poking around in > the file system > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java > c06d4e8fadf7aaba5432280195ef8524e6aadcb5 > > Diff: https://reviews.apache.org/r/56457/diff/ > > > Testing > ------- > > Tested under Eclipse, Idea and Gradle > > > Thanks, > > Bruce Schuchardt > >
