This is a really weird test, using a bunch of arrays pass things around. In
this case it looks like the DistributedMember objects were equal, but it
fails when because it's essentially validating the toStrings of the member
ids.

I think maybe we should just remove the validation of the toString method.
Maybe consider deprecating and removing ClientMembershipEvent.getMemberId
as well, since it seems like it's somewhat redundant.

-Dan

On Thu, Feb 9, 2017 at 2:33 PM, Kirk Lund <kl...@apache.org> wrote:

> Any opinions on this failure? I'm not sure if we should change the test,
> change our use of host name lookup or blacklist asf91 from our nightly
> build.
>
> org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.
> testSystemClientEventsInServer
>
> org.junit.ComparisonFailure:
> expected:<[67.195.81.13]9(2651)<ec><v39>:327...> but
> was:<[asf91]9(2651)<ec><v39>:327...>
> at org.junit.Assert.assertEquals(Assert.java:115)
> at org.junit.Assert.assertEquals(Assert.java:144)
> at
> org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.
> doTestSystemClientEventsInServer(UniversalMembershipListenerAda
> pterDUnitTest.java:946)
> at
> org.apache.geode.management.UniversalMembershipListenerAdapterDUnitTest.
> testSystemClientEventsInServer(UniversalMembershipListenerAda
> pterDUnitTest.java:731)
>

Reply via email to