> On Feb. 10, 2017, 12:24 a.m., Dan Smith wrote: > > Looks good - but I wonder if these are really all direct dependencies. Do > > we really have a direct dependency on bcel, for example? If not it seems > > like we shouldn't manually set the bcel version - we should let gradle pull > > whatever version is required by whatever dependency we have that uses bcel.
I used BCEL in the ClassPathLoader tests. I did notice some other dependencies in this version file arent acually used though and was hoping to delete those eventually. - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56520/#review165029 ----------------------------------------------------------- On Feb. 10, 2017, 12:07 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56520/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 12:07 a.m.) > > > Review request for geode, Anthony Baker, anilkumar gingade, Bruce Schuchardt, > Darrel Schneider, Hitesh Khamesra, Jacob Barrett, Jens Deppe, Jinmei Liao, > Jared Stewart, Kevin Duling, Udo Kohlmeyer, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Update several dependencies so that geode develop uses the latest version. > > These changes fully pass precheckin. Please let me know which dependencies > should NOT be updated for any reason and I'll retest with a list of > dependencies that it's ok to update and file appropriate Jira ticket(s). > > If there you see dependencies changed in the diff that require me to run any > tests not in precheckin, please let me know either in review or direct > message. > > > Diffs > ----- > > gradle/dependency-versions.properties a0b291e > > Diff: https://reviews.apache.org/r/56520/diff/ > > > Testing > ------- > > precheckin passed > > > Thanks, > > Kirk Lund > >
