----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56556/#review165168 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Feb. 10, 2017, 7:30 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56556/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2017, 7:30 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jinmei Liao, > Jared Stewart, Kevin Duling, and Udo Kohlmeyer. > > > Bugs: GEODE-2454 > https://issues.apache.org/jira/browse/GEODE-2454 > > > Repository: geode > > > Description > ------- > > GEODE-2454: use DistributedMember.getId() for memberId assertions > > This test is failing in the Geode Nightly Build because the assertion is > incorrect. It asserts that the MembershipEvent.getMemberId() is equal to > DistributedMember.toString(). It should instead assert that > MembershipEvent.getMemberId() is equal to DistributedMember.getId(). There > are multiple places in the code where it was using toString() instead of > getId(). > > I also deleted old comments from the code. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/management/UniversalMembershipListenerAdapterDUnitTest.java > e0d3d8b > > Diff: https://reviews.apache.org/r/56556/diff/ > > > Testing > ------- > > UniversalMembershipListenerAdapterDUnitTest > > > Thanks, > > Kirk Lund > >
