Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/3#discussion_r100877742
--- Diff: src/cppcache/src/CacheXmlParser.cpp ---
@@ -1165,7 +1166,7 @@ void CacheXmlParser::startPersistenceManager(const
xmlChar** atts) {
throw CacheXmlException(s.c_str());
}
- ACE_OS::strncpy(libraryFunctionName, (char*)atts[i], len);
+ std::strncpy(libraryFunctionName, (char*)atts[i], len);
--- End diff --
Maybe not is a great opportunity to fix these c-style casts that are
warnings in C++11 now when you are fixing other things in the file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
