[GitHub] geode pull request #398: Split the redis adapter into its own package

[galen-pivotal]

Github user galen-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/398#discussion_r101388974
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java 
---
    @@ -1330,21 +1360,12 @@ private void startMemcachedServer() {
       }
     
       private void startRedisServer() {
    -    int port = system.getConfig().getRedisPort();
    -    if (port != 0) {
    -      String bindAddress = system.getConfig().getRedisBindAddress();
    -      assert bindAddress != null;
    -      if 
(bindAddress.equals(DistributionConfig.DEFAULT_REDIS_BIND_ADDRESS)) {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_PORT_0,
    -            new Object[] {port});
    -      } else {
    -        getLoggerI18n().info(
    -            
LocalizedStrings.GemFireCacheImpl_STARTING_GEMFIRE_REDIS_SERVER_ON_BIND_ADDRESS_0_PORT_1,
    -            new Object[] {bindAddress, port});
    -      }
    -      this.redisServer = new GeodeRedisServer(bindAddress, port);
    -      this.redisServer.start();
    +    GeodeRedisService geodeRedisService = 
getService(GeodeRedisService.class);
    --- End diff --
    
    Also, whatever code gfsh uses to start the Redis adapter will have to stay 
in gfsh, unless there is a way to register extension commands with gfsh through 
some not-yet-existent method. This would be great, though, because we could 
plug in extensions that would change Geode's functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---