> On Feb. 16, 2017, 6:47 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java, > > line 599 > > <https://reviews.apache.org/r/56738/diff/1/?file=1636603#file1636603line599> > > > > instead of size() > 0 is !isEmpty()
New change does not use size. > On Feb. 16, 2017, 6:47 p.m., Darrel Schneider wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java, > > line 71 > > <https://reviews.apache.org/r/56738/diff/1/?file=1636604#file1636604line71> > > > > If you follow my previous advice then it seems like > > adviseAllPRServersWithInterestNodes should be > > adviseAllNonReplicatesPRServersWithInterestNodes and then you can get rid > > of the call in line 72 of removeAll(adviseReplicates()) We are looking at two different advisor here, for PR and bucket region. - anilkumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56738/#review165874 ----------------------------------------------------------- On Feb. 16, 2017, 8:50 p.m., anilkumar gingade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56738/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 8:50 p.m.) > > > Review request for geode, Darrel Schneider and Eric Shu. > > > Repository: geode > > > Description > ------- > > Tombstone: > As part of consistency checking, when an entry is destroyed, the member > temporarily retains the entry to detect possible conflicts with operations > that have occurred. The retained entry is referred to as a tombstone. > > When tombstones are removed, tombstone messages are sent to region replicas; > and in case of Partitioned Region (PR) messages are also sent to peer region > nodes for client events. > > Currently tombstone messages meant for clients that have all the keys removed > are getting sent to peer PR nodes even though no clients are registered on > those peers. > > Based on the number tombstone keys processed (by default 100000) this could > be large message sent to peer node which could impact the performance of the > system/cluster. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionAdvisor.java > b5b9cf4 > geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegion.java > 585f4e4 > > geode-core/src/main/java/org/apache/geode/internal/cache/TombstoneService.java > ca682bc > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PRTombstoneMessage.java > fa82560 > > geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RegionAdvisor.java > 0978585 > > geode-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java > 9780563 > > Diff: https://reviews.apache.org/r/56738/diff/ > > > Testing > ------- > > Added new test > precheckin > > > Thanks, > > anilkumar gingade > >
