Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/15#discussion_r101662122
  
    --- Diff: src/cppcache/src/TcrMessage.hpp ---
    @@ -1113,12 +1117,11 @@ class TcrMessageHelper {
           return NULL_OBJECT;
         } else if (!isObj) {
           // otherwise we're currently always expecting an object
    -      char exMsg[256];
    -      std::snprintf(exMsg, 255,
    -                    "TcrMessageHelper::readChunkPartHeader: "
    -                    "%s: part is not object",
    -                    methodName);
    -      LOGDEBUG("%s ", exMsg);
    +
    +      std::stringstream s;
    +      s << "TcrMessageHelper::readChunkPartHeader: " << methodName << ": 
part is not object\n";
    +      LOGDEBUG("%s ", s.str().c_str());
    --- End diff --
    
    Good question. I am still fascinated as to why std::snprintf isn't working 
correctly on Windows too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to