[ 
https://issues.apache.org/jira/browse/GEODE-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870962#comment-15870962
 ] 

ASF GitHub Bot commented on GEODE-2309:
---------------------------------------

Github user dgkimura commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/12#discussion_r101664490
  
    --- Diff: .ratignore ---
    @@ -23,10 +23,12 @@
     
     # expect script
     .*changepasswd$
    +.*winrm.cloud-init$
     
     # doxygen
     .*package-list$
     .*testframeworkdox.txt$
    +docs
    --- End diff --
    
    Good point.
    
    However, I tested that this seems to work.  I created a file `somedocs` and 
`docsblah`, both without licenses.  When I ran `rat` it flagged both of those 
files, which would make it seem like it doesn't treat this change as a regex?
    
    I couldn't seem to find apache-rat documentation for their regex.  If you 
know where they are could you point me to them?
    
    `$ java -jar ~/tools/apache-rat-0.12/apache-rat-0.12.jar --dir . 
--exclude-file .ratignore`
    
    ```
    *****************************************************
    
     Printing headers for text files without a valid license header...
     
    =====================================================
    == File: ./docsblah
    =====================================================
    no license
    
    =====================================================
    == File: ./somedocs
    =====================================================
    no license
    
    =====================================================
    ```


> Replace or add ASF copyright statements in source.
> --------------------------------------------------
>
>                 Key: GEODE-2309
>                 URL: https://issues.apache.org/jira/browse/GEODE-2309
>             Project: Geode
>          Issue Type: Task
>          Components: native client
>            Reporter: Jacob S. Barrett
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to