GitHub user bschuchardt opened a pull request:
https://github.com/apache/geode/pull/402
GEODE-2497 surprise members are never timed out during startup
Moved the creation of the timer to GMSMembershipManager.started()
Removed write-lock in timer-creation method since it's only called from
one place now
Altered the way that the timer-creation method finds the
InternalDistributedSystem. The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.
Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.
Altered the surprise-member unit test to run faster. It now completes in
under 10 seconds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-2497
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #402
----
commit 8d45ca22737282abe279d3c863478f904f2e1926
Author: Bruce Schuchardt <[email protected]>
Date: 2017-02-17T18:17:21Z
GEODE-2497 surprise members are never timed out during startup
Moved the creation of the timer to GMSMembershipManager.started()
Removed write-lock in timer-creation method since it's only called from
one place now
Altered the way that the timer-creation method finds the
InternalDistributedSystem. The old way of using getAnyInstance() was
the primary source of the problem since it returns null until startup
is completed.
Altered the surprise-member unit test to ensure that it's using the
timer and not relying on installation of a new membership view to clean
things up.
Altered the surprise-member unit test to run faster. It now completes in
under 10 seconds.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
