I've modified PR #13 to remove the vestigial executable and to elide the duplicate GEODE_ in the legacy include guards.
Sarge > On 17 Feb, 2017, at 11:06, pivotal-jbarrett <g...@git.apache.org> wrote: > > Github user pivotal-jbarrett commented on a diff in the pull request: > > https://github.com/apache/geode-native/pull/13#discussion_r101825168 > > --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- > @@ -1,7 +1,7 @@ > #pragma once > > -#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_ > -#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_ > +#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_ > --- End diff -- > > I see an argument that `include/geode/` is the root for the public > headers, therefore the guards should be `GEODE_ATTRIBUTESFACTORY_H_`. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > ---
