----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56801/#review165987 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java (line 2777) <https://reviews.apache.org/r/56801/#comment237855> Do you need the old filename pattern regex in a comment? The extensions are all explicitly defined in the new listFiles call so the commnet doesn't add anything to the readability of the code. - Ken Howe On Feb. 17, 2017, 10:21 p.m., Kevin Duling wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56801/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 10:21 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-2457: Replace org.apache.geode.internal.FileUtil with > org.apache.commons.io.FileUtils > > > Diffs > ----- > > > extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/installer/InstallerJUnitTest.java > e51241b0972089881c1f4b9a2fb6e0b13c1d8a7f > geode-assembly/src/test/java/org/apache/geode/BundledJarsJUnitTest.java > b7ada4a4d49d46937fb6c0c2d6af641fd73ec10e > > geode-assembly/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigurationServiceEndToEndDUnitTest.java > a96f8afe75675bb733956cf28bc129e6a7c23b25 > geode-core/src/main/java/org/apache/geode/internal/FileUtil.java > 2d729303a27179876e2f8a96c0542d796f426e16 > geode-core/src/main/java/org/apache/geode/internal/cache/DiskInitFile.java > 4023b71dcc0ff5d5b4e3d5cec8d9313dcf9e8dbc > geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java > e53aa5d55437116dc466e551c793af87f24012df > geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java > 270c8335a88c48fd3b036b65b50d7fd2b7734a81 > > geode-core/src/main/java/org/apache/geode/internal/cache/PersistentOplogSet.java > a71394139cd8cc4582122f2d587d0f4434b9ce12 > > geode-core/src/main/java/org/apache/geode/internal/cache/persistence/BackupManager.java > e4e5467383ed0cdfa31efa10864f7eb56362f8d5 > > geode-core/src/main/java/org/apache/geode/internal/cache/persistence/RestoreScript.java > 86f880e65a3b3eb3477f2a1fd62bd4a4772f44ee > > geode-core/src/main/java/org/apache/geode/internal/io/MainWithChildrenRollingFileHandler.java > 20d1c4ff92fbd54956334c923e1bacfea8825aa6 > > geode-core/src/main/java/org/apache/geode/internal/logging/MergeLogFiles.java > 7bb94ef92c8a641ae87bb6cdbe7b91b379427371 > > geode-core/src/test/java/org/apache/geode/cache/client/ClientCacheFactoryJUnitTest.java > f881d386d9e7fac8c87f7fd837a9b66e3a86d2d7 > geode-core/src/test/java/org/apache/geode/cache/query/QueryTestUtils.java > 2d6921b9a2087928dffebd2dc050f3967170962b > > geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryIndexUsingXMLDUnitTest.java > 66c4ecfce12c20cd4b1d3e363aa66206d947b8ef > > geode-core/src/test/java/org/apache/geode/cache/query/functional/IndexCreationJUnitTest.java > f126146d3098f009eda8388273b52758b7d0ee28 > > geode-core/src/test/java/org/apache/geode/distributed/AbstractLauncherIntegrationTestCase.java > 01151931473e882905a4443535f2c2306e34ff63 > geode-core/src/test/java/org/apache/geode/internal/FileUtilJUnitTest.java > 942059e110487f3f886ef5749134190768a87eac > > geode-core/src/test/java/org/apache/geode/internal/JarDeployerDUnitTest.java > 22f66a3efdb670684c0108ab22dc07c43e0265b1 > > geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java > 3852dee6613dd67ed85d61365c7ad6ca02306f78 > > geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldDUnitTest.java > 00bb6fb9064b46ef5622e7e11632a36ec71097dd > > geode-core/src/test/java/org/apache/geode/internal/PdxDeleteFieldJUnitTest.java > 1d18ed146382e36c894c72ab642e8055fd316df1 > geode-core/src/test/java/org/apache/geode/internal/PdxRenameDUnitTest.java > 4057069cf4c61bc843e7957b6bcb3be6335a0e5e > geode-core/src/test/java/org/apache/geode/internal/PdxRenameJUnitTest.java > cc393a2f70e0a08b5740e3caffbcd1bbd1d74006 > > geode-core/src/test/java/org/apache/geode/internal/cache/BackupDUnitTest.java > 10931e194d20369350720736a4435aa5998ca0cc > > geode-core/src/test/java/org/apache/geode/internal/cache/BackupJUnitTest.java > a89c0d13ececb47bf7345624d4e7d128e01d6a45 > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionAsyncRecoveryJUnitTest.java > 6955dc829330f8766c172da32795fd8ee6b98f7e > > geode-core/src/test/java/org/apache/geode/internal/cache/DiskRegionTestingBase.java > 55cabe7bb04c77b72b7de3dfe2bc5824d68a9799 > > geode-core/src/test/java/org/apache/geode/internal/cache/IncrementalBackupDUnitTest.java > 9c459a9b737fc80d7a7cd0242927abf2691855b3 > > geode-core/src/test/java/org/apache/geode/internal/cache/OplogRVVJUnitTest.java > 138f3acc5abb96831af60a43560334494793d60b > > geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionStatsJUnitTest.java > 2529639f200e3670cb7d108f70e2c0e9a3702401 > > geode-core/src/test/java/org/apache/geode/internal/cache/PersistentPartitionedRegionJUnitTest.java > 478f5e3f8827b78bc5aba5449698ce3fd3768b6c > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentColocatedPartitionedRegionDUnitTest.java > 47520bc8177feecf70dc0ede5a17607385b90dd3 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionTestBase.java > 09893be48c4dd0dbd9fadb8a07484e2e84430ee7 > > geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningTestBase.java > d8aa379a5393a3bd531766282f8b15403000e39c > > geode-core/src/test/java/org/apache/geode/internal/cache/persistence/BackupInspectorJUnitTest.java > 1da360e7b271642925f29c20f26a3c6d0a131975 > > geode-core/src/test/java/org/apache/geode/internal/cache/persistence/PersistentReplicatedTestBase.java > c76292e2a10525682cf655468e7fbc47292c5ea1 > > geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgrade2DUnitTest.java > 5106935f0922f248af2c7fc55a39dad736c7adc2 > > geode-core/src/test/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeDUnitTest.java > 54b51de73169429967018f3f5739fe4d49452531 > > geode-core/src/test/java/org/apache/geode/internal/logging/log4j/Log4J2PerformanceTest.java > 0bd50ab89f5665ff228e7d266e4e17687d7ef022 > > geode-core/src/test/java/org/apache/geode/internal/logging/log4j/LogWriterLoggerPerformanceTest.java > d4f36d335598867199f6200f43c50cb306a60594 > > geode-core/src/test/java/org/apache/geode/internal/net/SSLSocketIntegrationTest.java > d98c5d2f7361e08a3e10faf12bdedfe84e17cf49 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java > 91748069cbee8e556966215cea0c8801a04bde22 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java > 3729416368f664a70fc5a3226806b236a660b63f > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart1DUnitTest.java > 2fc8e844d319abcf19430cfb9cd09e2a64aab38c > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart2DUnitTest.java > d1f44d131bb6c4abe944d5bfd319ebe267b2f7b2 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart3DUnitTest.java > b6a4a5ba3bce03cae8c46442cb032ec270455ed9 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommandsExportLogsPart4DUnitTest.java > b712785b74e4f65fbfedbb362a129151e34c18bb > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueueCommandsDUnitTest.java > 685bd48a546258f0aba7c16f417e5dad5b764b59 > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/UserCommandsDUnitTest.java > 9611b396170e6ff08791a8d3493b01215c705b34 > geode-core/src/test/java/org/apache/geode/pdx/PdxAttributesJUnitTest.java > 753fcded418307cdbf8dcdc53ac588a9662037f2 > geode-core/src/test/java/org/apache/geode/pdx/PdxSerializableJUnitTest.java > 72645d91da9c5b55261de8cd7eded56390acfb0f > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java > d7b15fcebe941872c3759d598058a98abe5ba394 > geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java > 927008b6ec9dde3328f206e1311984cdb9939d06 > > geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java > 4620f1deb03b76452df3a8d95daf4294573f02b0 > > Diff: https://reviews.apache.org/r/56801/diff/ > > > Testing > ------- > > precheckin running > > > Thanks, > > Kevin Duling > >
