----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56803/#review166269 -----------------------------------------------------------
Ship it! There's a few more NOTICE files to be updated, looks good otherwise. - Anthony Baker On Feb. 21, 2017, 8:42 p.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56803/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 8:42 p.m.) > > > Review request for geode, Anthony Baker, Jacob Barrett, Jinmei Liao, and Kirk > Lund. > > > Repository: geode > > > Description > ------- > > Removed non-compliant ORJ.JSON implementation with a compliant opensource > ORG.JSON implementation > > > Diffs > ----- > > LICENSE 9bfdd83c9 > NOTICE 13a30d3bb > geode-assembly/src/main/dist/LICENSE 4769f9a55 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java > 8525b5862 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/json/GfJsonObject.java > 69666ff9d > > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java > e08d9b7c0 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java > 06060a4c6 > geode-json/build.gradle PRE-CREATION > geode-json/src/main/java/org/json/CDL.java d78935bd7 > geode-json/src/main/java/org/json/Cookie.java 21f88d8bd > geode-json/src/main/java/org/json/CookieList.java 35e1a97f4 > geode-json/src/main/java/org/json/HTTP.java 1e815aabe > geode-json/src/main/java/org/json/HTTPTokener.java 72c9b8878 > geode-json/src/main/java/org/json/JSON.java PRE-CREATION > geode-json/src/main/java/org/json/JSONArray.java edaefa420 > geode-json/src/main/java/org/json/JSONException.java b65efe25c > geode-json/src/main/java/org/json/JSONML.java b535614f8 > geode-json/src/main/java/org/json/JSONObject.java a2c6d8b6a > geode-json/src/main/java/org/json/JSONStringer.java 234e17451 > geode-json/src/main/java/org/json/JSONTokener.java 4dd2ba2cc > geode-json/src/main/java/org/json/JSONWriter.java 7d4704b21 > geode-json/src/main/java/org/json/XML.java ae6d61a49 > geode-json/src/main/java/org/json/XMLTokener.java f56a1f6a5 > geode-json/src/test/java/org/json/FileTest.java PRE-CREATION > geode-json/src/test/java/org/json/JSONArrayTest.java PRE-CREATION > geode-json/src/test/java/org/json/JSONFunctionTestObject.java PRE-CREATION > geode-json/src/test/java/org/json/JSONObjectTest.java PRE-CREATION > geode-json/src/test/java/org/json/JSONStringerTest.java PRE-CREATION > geode-json/src/test/java/org/json/JSONTokenerTest.java PRE-CREATION > geode-json/src/test/java/org/json/ParsingTest.java PRE-CREATION > geode-json/src/test/java/org/json/SelfUseTest.java PRE-CREATION > geode-json/src/test/resources/sample-01.json PRE-CREATION > > Diff: https://reviews.apache.org/r/56803/diff/ > > > Testing > ------- > > pre-checkin = completed. 1 Flaky failure, unrelated failure > > > Thanks, > > Udo Kohlmeyer > >