[
https://issues.apache.org/jira/browse/GEODE-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883200#comment-15883200
]
Kirk Lund commented on GEODE-2461:
----------------------------------
Removing cglib from explicit dependency declaration results in JMock failures.
Example:
{noformat}
org.apache.geode.management.internal.cli.commands.AbstractCommandsSupportJUnitTest
> testRegister FAILED
java.lang.IllegalArgumentException
at net.sf.cglib.asm.ClassReader.<init>(Unknown Source)
at net.sf.cglib.asm.ClassReader.<init>(Unknown Source)
at net.sf.cglib.asm.ClassReader.<init>(Unknown Source)
at
net.sf.cglib.proxy.BridgeMethodResolver.resolveAll(BridgeMethodResolver.java:61)
at net.sf.cglib.proxy.Enhancer.emitMethods(Enhancer.java:911)
at net.sf.cglib.proxy.Enhancer.generateClass(Enhancer.java:498)
at
net.sf.cglib.core.DefaultGeneratorStrategy.generate(DefaultGeneratorStrategy.java:25)
at
net.sf.cglib.core.AbstractClassGenerator.create(AbstractClassGenerator.java:216)
at net.sf.cglib.proxy.Enhancer.createHelper(Enhancer.java:377)
at net.sf.cglib.proxy.Enhancer.createClass(Enhancer.java:317)
at
org.jmock.lib.legacy.ClassImposteriser.proxyClass(ClassImposteriser.java:121)
at
org.jmock.lib.legacy.ClassImposteriser.imposterise(ClassImposteriser.java:66)
at org.jmock.Mockery.mock(Mockery.java:148)
at
org.apache.geode.management.internal.cli.commands.AbstractCommandsSupportJUnitTest.testRegister(AbstractCommandsSupportJUnitTest.java:330)
{noformat}
> Remove unnecessary explicit dependencies
> ----------------------------------------
>
> Key: GEODE-2461
> URL: https://issues.apache.org/jira/browse/GEODE-2461
> Project: Geode
> Issue Type: Wish
> Components: build
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> These unused entries are potential candidates for removal from
> gradle/dependency-versions.properties:
> * cdi-api.version
> * hadoop.version*
> * hbase.version (remove contains check from geode-assembly)
> * hibernate.version
> * hibernate-commons-annotations.version
> * hsqldb.version
> * jline.version
> * jsr305.version
> * paranamer.version
> * quartz.version
> * spymemcached.version? (remove testCompile from geode-core)
> These entries are actually for transitive dependencies and should have the
> explicit dependency removed:
> * activation.version
> * asm.version (done)
> * cglib.version (remove testRuntime from test.gradle)
> * classmate (remove compile from geode-web-api)
> * mortbay-jetty-servlet-api.version? (remove provided from geode-pulse)
> * scala.version (remove compile from geode-web-api)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
