[ 
https://issues.apache.org/jira/browse/GEODE-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883492#comment-15883492
 ] 

ASF GitHub Bot commented on GEODE-2439:
---------------------------------------

Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/32#discussion_r103031314
  
    --- Diff: src/tests/cpp/fwklib/Timer.hpp ---
    @@ -28,18 +28,18 @@
     
     #ifdef _WIN32
     
    -#include <time.h>
    -#include <stdio.h>
    -#include <stdlib.h>
    +#include <ctime>
    +#include <cstdio>
    +#include <cstdlib>
     #include <windows.h>
     #include <winbase.h>
     
     #endif
     
     #ifdef _SOLARIS
     
    -#include <time.h>
    -#include <stdio.h>
    +#include <ctime>
    --- End diff --
    
    I bet this could be cleaned up by moving time, cstudio, cstdlib out of the 
conditionals since all platforms have those includes now.



> Replace all non-standard types in all public includes / API
> -----------------------------------------------------------
>
>                 Key: GEODE-2439
>                 URL: https://issues.apache.org/jira/browse/GEODE-2439
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Ernest Burghardt
>
> research other non-standard types in API, ACE_Time



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to