----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57225/#review167609 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On March 1, 2017, 11:45 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57225/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 11:45 p.m.) > > > Review request for geode, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and > xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Added try catch around retrieving lucene index to handle cache clossed > exception > Added catch during bucket querying to handle cache closed exception > minor refactoring to break down the execute method > Modified expected exception in tests to be more specific for certain tests > Added tests > > > Diffs > ----- > > > geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java > dd70480 > > geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java > 6a9af9b > > > Diff: https://reviews.apache.org/r/57225/diff/1/ > > > Testing > ------- > > geode-lucene:precheckin > > > Thanks, > > Jason Huynh > >