GitHub user PivotalSarge opened a pull request:
https://github.com/apache/geode-native/pull/48
GEODE-2578: Remove 64 KiB limit on query strings.
- Remove artificial cap of 65535 for query string
length by using 32 bits for the length of query
strings in DataOutput::writeFullUTF().
- Rename parameter to TcrMessage::writeStringPart()
whose name is misleading due to copy-and-paste.
- Add three unit tests for query-related messages:
* testConstructorEXECUTECQ_MSG_TYPE
* testConstructorWithGinormousQueryEXECUTECQ_MSG_TYPE
* testConstructorEXECUTECQ_WITH_IR_MSG_TYPE
- Fix the cursor advance tests to not depend on
specific values for buffer length and not to
test remaining buffer length.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PivotalSarge/geode-native feature/GEODE-2578
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode-native/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 128ab410d3aaae69186c0a41ed3a1310ef982382
Author: Sarge <mdo...@pivotal.io>
Date: 2017-03-07T19:26:53Z
GEODE-2578: Remove 64 KiB limit on query strings.
- Remove artificial cap of 65535 for query string
length by using 32 bits for the length of query
strings in DataOutput::writeFullUTF().
- Rename parameter to TcrMessage::writeStringPart()
whose name is misleading due to copy-and-paste.
- Add three unit tests for query-related messages:
* testConstructorEXECUTECQ_MSG_TYPE
* testConstructorWithGinormousQueryEXECUTECQ_MSG_TYPE
* testConstructorEXECUTECQ_WITH_IR_MSG_TYPE
- Fix the cursor advance tests to not depend on
specific values for buffer length and not to
test remaining buffer length.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
