[
https://issues.apache.org/jira/browse/GEODE-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902285#comment-15902285
]
ASF GitHub Bot commented on GEODE-2595:
---------------------------------------
GitHub user upthewaterspout opened a pull request:
https://github.com/apache/geode/pull/421
GEODE-2595: Change LuceneService.createIndex to use a factory
Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index.
This allows us to introduce new options to the index create without
breaking backwards compatibility in the future.
@ladyVader @nabarunnag @boglesby
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/upthewaterspout/incubator-geode
feature/GEODE-2595
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #421
----
commit f912be793ff7a73855df903148d4b74dfdc415b9
Author: Dan Smith <upthewatersp...@apache.org>
Date: 2017-03-09T01:15:44Z
GEODE-2595: Change LuceneService.createIndex to use a factory
Changing LuceneService.createIndex to createIndexFactory and
using a factory pattern to create the index.
This allows us to introduce new options to the index create without
breaking backwards compatibility in the future.
----
> Change LuceneService.createIndex to use a factory pattern
> ---------------------------------------------------------
>
> Key: GEODE-2595
> URL: https://issues.apache.org/jira/browse/GEODE-2595
> Project: Geode
> Issue Type: Improvement
> Components: lucene
> Reporter: Dan Smith
>
> Before we remove the Experimental annotation from the LuceneService, we
> should change createIndex to use a factory pattern rather than having a
> single method with parameters to create the index. In other words, the method
> needs to change from:
> {code}
> luceneService.createIndex(region, index, ...)
> {code}
> to
> {code}
> luceneService.createIndexFactory()
> .setXXX()
> .setYYY()
> .create()
> {code}
> This will allow us to add additional set methods in the future to configure
> other things like the async event queue batch size, etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
